Remove stale open_conext_monitor route block from routes.yaml#2039
Merged
Conversation
The release/7.0 -> main merge (f0e306e) silently reintroduced the open_conext_monitor route block that was correctly removed from main during the Symfony 6.4 upgrade (ae5fd8d). release/7.0 pins openconext/monitor-bundle 4.2.0, which has no Symfony Flex recipe and requires this manual routes.yaml entry. main uses monitor-bundle 4.3.1, which auto-installs its own route file (config/routes/open_conext_monitor.yaml) via Flex, pointing at @OpenConextMonitorBundle/src/Controller instead. The Resources/config/routing.yml path referenced by the stale block no longer exists in 4.3.1, breaking route compilation and failing the build. Monitoring routes (/internal/health, /internal/info) continue to work via the existing Flex-installed config/routes/open_conext_monitor.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release/7.0 > main merge (f0e306e) silently reintroduced the open_conext_monitor route block that was correctly removed from main during the Symfony 6.4 upgrade (ae5fd8d).
release/7.0 pins openconext/monitor-bundle 4.2.0, which has no Symfony Flex recipe and requires this manual routes.yaml entry. main uses monitor-bundle 4.3.1, which auto-installs its own route file (config/routes/open_conext_monitor.yaml) via Flex, pointing at @OpenConextMonitorBundle/src/Controller instead. The Resources/config/routing.yml path referenced by the stale block no longer exists in 4.3.1, breaking route compilation and failing the build.
Monitoring routes (/internal/health, /internal/info) continue to work via the existing Flex-installed config/routes/open_conext_monitor.yaml.