feat(stream-microsoft-sentinel-intel): add native azure auth (#7063) - #7064
feat(stream-microsoft-sentinel-intel): add native azure auth (#7063)#7064Renizmy wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Microsoft Sentinel Intel stream connector to support “native” Azure authentication by falling back to DefaultAzureCredential when explicit app-registration credentials aren’t provided, aligning the connector with Managed Identity / Workload Identity use cases from #7063.
Changes:
- Make
tenant_id,client_id, andclient_secretoptional and validate they are provided consistently (all-or-none). - Add runtime fallback to
DefaultAzureCredentialwhen app-registration credentials are not set. - Update documentation and generated metadata to reflect the new authentication options.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| stream/microsoft-sentinel-intel/src/microsoft_sentinel_intel/settings.py | Makes Azure app-registration fields optional and adds a config-level consistency validator. |
| stream/microsoft-sentinel-intel/src/microsoft_sentinel_intel/client.py | Chooses between ClientSecretCredential and DefaultAzureCredential for ARM auth. |
| stream/microsoft-sentinel-intel/README.md | Documents the two auth modes and updates setup guidance/snippets. |
| stream/microsoft-sentinel-intel/docker-compose.yml | Adds guidance comments for optional auth env vars in the example compose file. |
| stream/microsoft-sentinel-intel/metadata/connector_config_schema.json | Updates schema defaults/required fields to reflect optional auth variables. |
| stream/microsoft-sentinel-intel/metadata/CONNECTOR_CONFIG_DOC.md | Updates generated config documentation to mark auth vars as optional with null default. |
…enCTI-Platform#7064 Use explicit is-not-None checks for the auth credential selection and reject blank/whitespace-only tenant_id/client_id/client_secret at config validation instead of letting them silently fall through to DefaultAzureCredential. Also comment out the app-registration example vars in docker-compose.yml/README.md so copying the example verbatim uses DefaultAzureCredential by default, apply black formatting, and add settings test coverage for the auth fallback.
|
Hi @Renizmy 👋 (cc @romain-filigran),one question about the native Azure auth added here. Making At runtime, a catalog-deployed (non-Azure-native) container then falls through to Does this seem like a real problem to you? If so, what about an explicit |

Proposed changes
Related issues
Checklist