Skip to content

fix(parity): stop keying track_downloads on txhash #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rickyrombo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(parity): stop keying track_downloads on txhash #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkg/etl/parity/tables.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,9 +425,15 @@ var compareTables = []compareTable{
},
},
{
Name: "track_downloads",
IDCols: []string{"parent_track_id", "track_id", "txhash"},
Columns: []string{"user_id"},
Name: "track_downloads",
// NOT txhash: the migration rewrites chain provenance, so a txhash in
// the reference never appears on the indexed side and every row reports
// as missing -- a 100% false failure that hid a real created_at bug
// underneath it. created_at is the closest thing to a natural key here
// (it is not unique for ~500 of 76,960 rows, which is still vastly
// better than a key that cannot match at all).
IDCols: []string{"parent_track_id", "track_id", "user_id", "created_at"},
Columns: []string{"city", "region", "country"},
Where: "true",
SampleCol: "track_id",
Aggregates: []aggCheck{
Expand Down
Loading