Skip to content

use DriverVectorCube in chunk_polygon Open-EO/openeo-python-driver#288#801

Open
JeroenVerstraelen wants to merge 1 commit intomasterfrom
288-apply_polygon-previously-known-as-chunk_polygon-abuses-multipolygon-as-collection-of-polygons-in-its-internal-api-1
Open

use DriverVectorCube in chunk_polygon Open-EO/openeo-python-driver#288#801
JeroenVerstraelen wants to merge 1 commit intomasterfrom
288-apply_polygon-previously-known-as-chunk_polygon-abuses-multipolygon-as-collection-of-polygons-in-its-internal-api-1

Conversation

@JeroenVerstraelen
Copy link
Copy Markdown
Contributor

No description provided.

# TODO: it's wrong to use MultiPolygon as a collection of polygons. MultiPolygons should be handled as single, atomic "features"
# also see https://github.com/Open-EO/openeo-python-driver/issues/288
chunks: MultiPolygon,
chunks: DriverVectorCube,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes an API signature defined in openeo-python-driver. I don't think there is PR for that already

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is, you can find it here: Open-EO/openeo-python-driver#291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apply_polygon (previously known as chunk_polygon) abuses MultiPolygon as collection of polygons in its internal API

2 participants