Repository navigation
Only offer DPD and DPT objects as device element children - #37
Open
sujandumaru wants to merge 1 commit into
Open
sujandumaru wants to merge 1 commit into
sujandumaru wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A device element can only have device process data and device property objects as its children. AgIsoStack enforces this when it loads a pool, but the editor was not enforcing it when you build one.
Before. The "Add Child Object Reference" list showed almost every object in the pool. Open
EXAMPLE.ddopand click the "Sprayer" element: the box already says "AgIsoStack++ UnitTest", which is the device itself, and pressing "Add Object" makes thedevice a child of the element. Value presentation objects were in the list too. The editorsaves such a file without complaining, and then fails to load it back with
[DDOP]: A DET object may only have DPD and DPT children.After. The list has process data and property objects only, so you can not pick anything else. The same element now opens on "Actual Work State" instead of the device. And if the pool has no process data or property object yet, the panel tells you to add one first, instead of showing an empty picker.
I tested this on
EXAMPLE.ddopandEXAMPLE_V4.ddop. Adding a child still works and the pools still save and load. The round trip tests do not link the GUI, so there is no new test here.