Skip to content

fix: forward noble BLE write options through desktop preload #12928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
originalix wants to merge 3 commits into
base: hotfix/v6.5.2
Choose a base branch
from
+197 −185
Open

fix: forward noble BLE write options through desktop preload #12928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cf453b
fix: forward noble BLE write options through desktop preload
originalix Aug 18, 2026
3a94b42
chore: upgrade hardware SDK to 1.2.0-alpha.180
originalix Aug 21, 2026
9ba4d88
chore: upgrade hardware SDK to 1.2.0-alpha.181
originalix Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
},
"dependencies": {
"@napi-rs/keyring": "^1.3.0",
"@onekeyfe/hd-common-connect-sdk": "1.2.0-alpha.176",
"@onekeyfe/hd-core": "1.2.0-alpha.176",
"@onekeyfe/hd-transport-usb": "1.2.0-alpha.176",
"@onekeyfe/hd-common-connect-sdk": "1.2.0-alpha.181",
"@onekeyfe/hd-core": "1.2.0-alpha.181",
"@onekeyfe/hd-transport-usb": "1.2.0-alpha.181",
"proper-lockfile": "^4.1.2"
}
}
9 changes: 7 additions & 2 deletions apps/desktop/app/preload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,13 @@ const desktopApi = {
isDesktopBleConnectedOnlyScopeActive(uuid)
? Promise.resolve()
: ipcRenderer.invoke(EOneKeyBleMessageKeys.NOBLE_BLE_UNSUBSCRIBE, uuid),
write: (uuid: string, data: string) =>
ipcRenderer.invoke(EOneKeyBleMessageKeys.NOBLE_BLE_WRITE, uuid, data),
write: (uuid: string, data: string, options?: { pacingDelayMs?: number }) =>
ipcRenderer.invoke(
EOneKeyBleMessageKeys.NOBLE_BLE_WRITE,
uuid,
data,
options,
),
cancelPairing: () =>
ipcRenderer.invoke(EOneKeyBleMessageKeys.NOBLE_BLE_CANCEL_PAIRING),
onNotification: (callback: (deviceId: string, data: string) => void) => {
Expand Down
40 changes: 20 additions & 20 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,21 +158,21 @@
"@onekeyfe/cross-inpage-provider-injected": "2.2.73",
"@onekeyfe/cross-inpage-provider-types": "2.2.73",
"@onekeyfe/extension-bridge-hosted": "2.2.73",
"@onekeyfe/hd-ble-sdk": "1.2.0-alpha.176",
"@onekeyfe/hd-common-connect-sdk": "1.2.0-alpha.176",
"@onekeyfe/hd-core": "1.2.0-alpha.176",
"@onekeyfe/hd-shared": "1.2.0-alpha.176",
"@onekeyfe/hd-transport": "1.2.0-alpha.176",
"@onekeyfe/hd-transport-electron": "1.2.0-alpha.176",
"@onekeyfe/hd-web-sdk": "1.2.0-alpha.176",
"@onekeyfe/hwk-adapter-core": "1.2.0-alpha.176",
"@onekeyfe/hwk-ledger-adapter": "1.2.0-alpha.176",
"@onekeyfe/hwk-ledger-connector-ble": "1.2.0-alpha.176",
"@onekeyfe/hwk-ledger-connector-webhid": "1.2.0-alpha.176",
"@onekeyfe/hwk-trezor-adapter": "1.2.0-alpha.176",
"@onekeyfe/hwk-trezor-connector-electron-ble": "1.2.0-alpha.176",
"@onekeyfe/hwk-trezor-connector-rn-ble": "1.2.0-alpha.176",
"@onekeyfe/hwk-trezor-connector-webusb": "1.2.0-alpha.176",
"@onekeyfe/hd-ble-sdk": "1.2.0-alpha.181",
"@onekeyfe/hd-common-connect-sdk": "1.2.0-alpha.181",
"@onekeyfe/hd-core": "1.2.0-alpha.181",
"@onekeyfe/hd-shared": "1.2.0-alpha.181",
"@onekeyfe/hd-transport": "1.2.0-alpha.181",
"@onekeyfe/hd-transport-electron": "1.2.0-alpha.181",
"@onekeyfe/hd-web-sdk": "1.2.0-alpha.181",
"@onekeyfe/hwk-adapter-core": "1.2.0-alpha.181",
"@onekeyfe/hwk-ledger-adapter": "1.2.0-alpha.181",
"@onekeyfe/hwk-ledger-connector-ble": "1.2.0-alpha.181",
"@onekeyfe/hwk-ledger-connector-webhid": "1.2.0-alpha.181",
"@onekeyfe/hwk-trezor-adapter": "1.2.0-alpha.181",
"@onekeyfe/hwk-trezor-connector-electron-ble": "1.2.0-alpha.181",
"@onekeyfe/hwk-trezor-connector-rn-ble": "1.2.0-alpha.181",
"@onekeyfe/hwk-trezor-connector-webusb": "1.2.0-alpha.181",
"@onekeyfe/onekey-cross-webview": "2.2.73",
"@polkadot/extension-inject": "0.54.1",
"@polkadot/types": "14.3.1",
Expand Down Expand Up @@ -416,11 +416,11 @@
"@reown/appkit-ethers5-react-native": "https://github.com/OneKeyHQ/app-modules#9d96daccc13625e5b3c8b236f9357956b049b884",
"@reown/appkit-scaffold-react-native": "https://github.com/OneKeyHQ/app-modules#ef39e1c6682f8b50dc019a851f6e2211392d353a",
"@reown/appkit-scaffold-utils-react-native": "https://github.com/OneKeyHQ/app-modules#aa31ef69e5058bb822c40f0a706ee9bdd191b005",
"@onekeyfe/hd-core": "1.2.0-alpha.176",
"@onekeyfe/hd-shared": "1.2.0-alpha.176",
"@onekeyfe/hd-transport": "1.2.0-alpha.176",
"@onekeyfe/hd-transport-http": "1.2.0-alpha.176",
"@onekeyfe/hd-transport-web-device": "1.2.0-alpha.176",
"@onekeyfe/hd-core": "1.2.0-alpha.181",
"@onekeyfe/hd-shared": "1.2.0-alpha.181",
"@onekeyfe/hd-transport": "1.2.0-alpha.181",
"@onekeyfe/hd-transport-http": "1.2.0-alpha.181",
"@onekeyfe/hd-transport-web-device": "1.2.0-alpha.181",
"promise": "^8.3.0",
"metro": "0.83.2",
"metro-babel-transformer": "0.83.2",
Expand Down
9 changes: 8 additions & 1 deletion packages/shared/types/desktop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,14 @@ export type INobleBleApi = {
disconnect: (uuid: string) => Promise<void>;
subscribe: (uuid: string) => Promise<void>;
unsubscribe: (uuid: string) => Promise<void>;
write: (uuid: string, data: string) => Promise<void>;
// options must reach the main handler: the transport suppresses per-packet
// write pacing for V2 devices via pacingDelayMs; dropping it silently
// re-enables the default delay on every packet.
write: (
uuid: string,
data: string,
options?: { pacingDelayMs?: number },
) => Promise<void>;
cancelPairing: () => Promise<void>;
onNotification: (
callback: (deviceId: string, data: string) => void,
Expand Down
Loading
Loading