fix: resolve third-party hardware wallet avatars per device model OK-60448 - #12912
Merged
originalix merged 3 commits intoAug 18, 2026
Merged
Conversation
Ledger and Trezor wallets all shared one generic placeholder image regardless of physical model. Add a resolver that maps the device's persisted vendorModel (SDK code) / vendorModelName to a per-model avatar key, fix refillWalletInfo (which ran on every wallet read) to stop forcing avatars back to the generic vendor key, and wire the resolver through onboarding scan lists, BLE binding, and the Tray.
ByteZhang1024
requested review from
ezailWang,
huhuanming,
originalix,
revan-zhang and
sidmorizon
as code owners
August 17, 2026 15:29
ByteZhang1024
changed the title
Contributor
|
@codex review |
Contributor
|
@codex security review |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4753d0e448
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The ledger/trezor fallback keys pointed at the new Nano X / Safe 7 artwork, so an unrecognized or metadata-less device would render as that specific model instead of a neutral placeholder. Restore the original generic placeholder art for the two fallback keys and add a regression test asserting they stay byte-distinct from any specific-model asset.
zhaono1
approved these changes
Aug 18, 2026
zhaono1
enabled auto-merge (squash)
August 18, 2026 01:42
originalix
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK-60448
Ledger and Trezor wallets all shared one generic placeholder image regardless of physical model. Add a resolver that maps the device's persisted vendorModel (SDK code) / vendorModelName to a per-model avatar key, fix refillWalletInfo (which ran on every wallet read) to stop forcing avatars back to the generic vendor key, and wire the resolver through onboarding scan lists, BLE binding, and the Tray.