Skip to content

fix: align perp dex source labels(OK-59905) - #12907

Merged
originalix merged 1 commit into
OneKeyHQ:release/v6.5.0from
Kahnchan:fix/ok-59905
Aug 18, 2026
Merged

fix: align perp dex source labels(OK-59905)#12907
originalix merged 1 commit into
OneKeyHQ:release/v6.5.0from
Kahnchan:fix/ok-59905

Conversation

@Kahnchan

@Kahnchan Kahnchan commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

OK-59905


Issue

Summary

  • Preserve and display HIP-3 DEX source labels (xyz / para) in Wallet Home market favorites and perpetual categories.
  • Reuse the existing perps display mapping so favorite and category rows render consistent source badges.
  • Align the Native perps ticker badge line heights with the shared DEX badge.

Intent & Context

OK-59905 reports that Wallet Home market favorites and perpetual lists do not show the xyz / para source labels. During Native verification, the DEX badge in the perps ticker was also visibly shorter than its adjacent badges.

Root Cause

The Wallet Home perps mapper kept the display symbol but dropped the DEX prefix from the server token name. The Native ticker used implicit React Native text line heights for its local badges while the shared PerpDexBadge uses a fixed 16px line height.

Design Decisions

  • Parse the source through the existing parseDexCoin utility and render it with the existing PerpDexBadge component.
  • Reuse the same perps display mapper for favorites and category data to keep both paths consistent.
  • Normalize only the local Native ticker badge line heights instead of changing the shared badge sizing across Market and Home surfaces.

Changes Detail

  • Add perpsDexLabel to the Wallet Home market display model and forward it to the shared token identity row.
  • Preserve xyz and para labels when mapping server perps tokens, with coverage for main-DEX tokens that should remain unlabeled.
  • Set the Native perps ticker labels to a consistent 16px line height.

Risk Assessment

  • Risk Level: Low
  • Affected Platforms: Mobile, Desktop, Web, Extension
  • Risk Areas: Wallet Home perps row rendering and Native perps ticker badge layout.

Test plan

  • Run focused Jest coverage for Wallet Home and Market perps token mapping (2 suites, 7 tests).
  • Run yarn agent:check --profile commit.
  • Run yarn agent:check --profile pr.
  • Verify Wallet Home favorites and perpetual categories show xyz / para badges on Native.
  • Verify the Native perps ticker badges have matching heights.

@sidmorizon

Copy link
Copy Markdown
Contributor

@codex review

@sidmorizon

Copy link
Copy Markdown
Contributor

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 0c11316b0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@originalix originalix added the release-ready This PR should be included in the next release label Aug 18, 2026
@originalix
originalix merged commit 6c7cf53 into OneKeyHQ:release/v6.5.0 Aug 18, 2026
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-ready This PR should be included in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants