Skip to content

chore: remove unused MV3 webRequest permission - #12884

Open
sidmorizon wants to merge 1 commit into
xfrom
codex/remove-unused-mv3-webrequest
Open

chore: remove unused MV3 webRequest permission#12884
sidmorizon wants to merge 1 commit into
xfrom
codex/remove-unused-mv3-webrequest

Conversation

@sidmorizon

Copy link
Copy Markdown
Contributor

Summary

  • remove the unused webRequest permission from the MV3 manifest
  • remove the adjacent obsolete webRequestBlocking comments
  • keep Keyless host permissions and legacy MV2 routing code unchanged

Rationale

All current extension development, build, release, performance, and E2E entry points produce Manifest V3. The only chrome.webRequest listener is guarded by !platformEnv.isManifestV3 and handles legacy MV2 extension-internal route redirects, so MV3 has no runtime consumer for this permission.

Removing it reduces the extension permission surface without changing website injection or the Keyless web flow.

Validation

  • yarn app:ext:build
  • generated apps/ext/build/chrome_v3/manifest.json is MV3 and does not contain webRequest
  • manifest lint, formatting, staged lint, and agent context checks ✅
  • yarn agent:check --profile commit and --profile pr reach an unrelated existing origin/x TypeScript error at packages/kit/src/views/Market/MarketHomeV2/layouts/MobileLayout.native.tsx:873 (tabPressAnimationEnabled is absent from the current component type) ⚠️

@sidmorizon
sidmorizon marked this pull request as ready for review August 14, 2026 08:47
@sidmorizon
sidmorizon enabled auto-merge (squash) August 14, 2026 08:47
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@sidmorizon

Copy link
Copy Markdown
Contributor Author

@codex review

@sidmorizon

Copy link
Copy Markdown
Contributor Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 15cf2628d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidmorizon

Copy link
Copy Markdown
Contributor Author

@cursoragent review

@cursor

cursor Bot commented Aug 18, 2026

Copy link
Copy Markdown

Taking a look!

Open in Web Open in Cursor 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants