chore: remove unused MV3 webRequest permission - #12884
Open
sidmorizon wants to merge 1 commit into
Open
Conversation
sidmorizon
marked this pull request as ready for review
August 14, 2026 08:47
sidmorizon
requested review from
ezailWang,
huhuanming,
originalix and
revan-zhang
as code owners
August 14, 2026 08:47
sidmorizon
enabled auto-merge (squash)
August 14, 2026 08:47
|
You have reached your Codex usage limits for security reviews. Please try again later. |
originalix
approved these changes
Aug 14, 2026
Contributor
Author
|
@codex review |
Contributor
Author
|
@codex security review |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
Author
|
@cursoragent review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
webRequestpermission from the MV3 manifestwebRequestBlockingcommentsRationale
All current extension development, build, release, performance, and E2E entry points produce Manifest V3. The only
chrome.webRequestlistener is guarded by!platformEnv.isManifestV3and handles legacy MV2 extension-internal route redirects, so MV3 has no runtime consumer for this permission.Removing it reduces the extension permission surface without changing website injection or the Keyless web flow.
Validation
yarn app:ext:build✅apps/ext/build/chrome_v3/manifest.jsonis MV3 and does not containwebRequest✅yarn agent:check --profile commitand--profile prreach an unrelated existingorigin/xTypeScript error atpackages/kit/src/views/Market/MarketHomeV2/layouts/MobileLayout.native.tsx:873(tabPressAnimationEnabledis absent from the current component type)