Sphurthy taking over for Taariq: Adding a Lesson Plan Builder UI and update routes#4978
Sphurthy taking over for Taariq: Adding a Lesson Plan Builder UI and update routes#4978TaariqMansurie wants to merge 15 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
one-community
added
the
High Priority - Please Review First
|
I tried testing the functionalities by switching to "taariq-feature-lesson-plan-builder-frontend", but I see POST /api/educator/assign-tasks return 404 error. Not sure if I have to have any records in the database prior to testing. 
|
ManojPuttaswamy
left a comment
ManojPuttaswamy
left a comment
There was a problem hiding this comment.
please cleanup comments which aren't necessary
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Taariq,
I have reviewed your PR locally and have found the below issue:
- The UI of the manually assigned and auto assigned does not show the pop of color as it does in light mode
- The calendar is in light mode when the application is in dark mode
- As you can see in the below video, there is a huge delay in terms of notification pop up which can cause people to assume that it did not get clicked and they can click it multiple times just like i did and the notification appears multiple times
- Also what exactly does 1404 mean in the notification.
- And the UI is not mobile responsive
4978.mov
one-community
changed the title
…ighestGoodNetworkApp into taariq-feature-lesson-plan-builder-frontend Made-with: Cursor # Conflicts: # package-lock.json
|
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hey Sphurthy,
Great work on the improvements! The calendar dark mode, notification delay, notification message, and mobile responsiveness are all fixed.
Two things left to fix:
- The manually assigned and auto-assigned UI does not show the color highlight in dark mode like it does in light mode.
- The Duplicate button text is not aligned properly
kunchalasireesha
left a comment
kunchalasireesha
left a comment
There was a problem hiding this comment.
Hi Spurthy, it looks like this PR currently has merge conflicts with the base branch. Could you please rebase or merge the latest changes from development into your branch and resolve the conflicts? Once the build passes, I’ll finish the review.
DeepighaJ
left a comment
DeepighaJ
left a comment
There was a problem hiding this comment.
Checked into current branch and tested PR locally
Adding assignments and Assign Lesson plan on confirm works as expected with notifications.
Save Lesson Plan with notification and Auto-assigned at time status also works as expected.
Issues: There are some UI inconsistencies.
- The calendar icon inside the Due Date field appears cramped and too close to the text (05/27/).
- The Duplicate buttons are larger than the Select buttons and dominate the row visually.
- There is excessive blank space between the last subtask row and the Total section.
- The Add subtask and Assign Lesson Plan buttons alignment is not good
8 participants
Description
This PR adds the UI and API integration for the "Assign Lesson Plan" feature. Educators and admins can assign tasks to students manually via a button or automatically upon saving.
Implements # (PRIORITY HIGH) Phase 4 - Assign Lesson Plan - Front end and UI (WIP Taariq)
Related PRS (if any):
This frontend PR is related to the backend PR 2145
To test this frontend PR, you need to have the corresponding backend branch running locally.
…
Main changes explained:
…
How to test:
1.check into current branch
2. do yarn install and yarn start to run this PR locally
3. Clear site data/cache
4. log in as an admin or educator user
5. go to the Lesson Plan Builder page
6. verify manual assignment: Click "Assign Lesson Plan", click "Confirm" in the modal, and verify the notification appears.
7. verify auto assignment: Click "Save Lesson Plan" and verify the UI updates with the "Auto-assigned at [Time]" status.
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.