Add support for fulu fork epoch and bpo schedule by james-prysm · Pull Request #15975 · OffchainLabs/prysm

james-prysm · 2025-11-04T16:36:40Z

What type of PR is this?

Other

What does this PR do? Why is it needed?

as per ethereum/consensus-specs#4689

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Acknowledgements

I have read CONTRIBUTING.md.
I have included a uniquely named changelog fragment file.
I have added a description to this PR with sufficient context for reviewers to understand this PR.

james-prysm · 2025-11-04T21:11:24Z

+
+if [ "$#" -lt 2 ]; then
+  echo "Usage: $0 <network> <commit_sha> [workspace_file]" >&2
+  echo "  network: mainnet | holesky | sepolia | hoodi" >&2


This is just a script to update the WORKSPACE in the future for ethclient package verifying configs

james-prysm · 2025-11-04T21:27:05Z

 	genesisTime := time.Now()
 	genesisValidatorsRoot := make([]byte, 32)
+	custodyInfoSet := make(chan struct{})
+	close(custodyInfoSet) // Close immediately since custodyInfo is already set


This is required because the custody check is enabled now that we have fulu set

kasey · 2025-11-04T21:51:25Z

+export ARCHIVE_NAME URL STRIP_PREFIX INTEGRITY
+
+# Update integrity
+perl -0pi -e '


Why are you using perl for this?

I didn't put much thought into this script and just got it generated, did some tests, saw it worked and just went with it. will change it to use something standard.

maybe for the sake of this PR i'll just remove this for now

I updated the values manually at first but it was tedious so i just tried to get ai to automate

This reverts commit 25e8183.

This reverts commit 583df80.

This reverts commit 3c76525.

This reverts commit 8c701bf.

james-prysm · 2025-11-05T21:09:52Z

will merge fulu-p2p-rpc-test-fixes back in after discussing offline

prestonvanloon · 2025-11-05T21:46:01Z

@@ -132,8 +132,8 @@ func TestNextForkData(t *testing.T) {
 		{
 			name:              "after last bpo - should be far future epoch and 0x00000000",


This test doesn't match the data here. The data is neither far future epoch or 0x000000

prestonvanloon · 2025-11-05T21:48:19Z

+	params.SetupTestConfigCleanup(t)
+	config := params.BeaconConfig()
+	config.FuluForkEpoch = 0
+	params.OverrideBeaconConfig(config)


This is also a hack. Why not fix the test to support fulu or use a block number that is in electra or something other than unsetting the fulu fork epoch?

reverted, was due to merging from separate pr

Co-authored-by: Preston Van Loon <[email protected]>

james-prysm · 2025-11-05T22:14:02Z

 		},
 		{
-			name:              "after last bpo - should be far future epoch and 0x00000000",
+			name:              "post last full fork, fulu bpo 1",


@kasey I updated this test name based on feedback it gives the bpo 1 after setting

…the guard

* wip * fixing tests * adding script to update workspace for eth clients * updating test sepc to 1.6.0 and fixing broadcaster test * fix specrefs * more ethspecify fixes * still trying to fix ethspecify * fixing attestation tests * fixing sha for consensus specs * removing script for now until i have something more standard * fixing more p2p tests * fixing discovery tests * attempting to fix discovery test flakeyness * attempting to fix port binding issue * more attempts to fix flakey tests * Revert "more attempts to fix flakey tests" This reverts commit 25e8183. * Revert "attempting to fix port binding issue" This reverts commit 583df80. * Revert "attempting to fix discovery test flakeyness" This reverts commit 3c76525. * Revert "fixing discovery tests" This reverts commit 8c701bf. * Revert "fixing more p2p tests" This reverts commit 140d5db. * Revert "fixing attestation tests" This reverts commit 26ded24. * fixing attestation tests * fixing more p2p tests * fixing discovery tests * attempting to fix discovery test flakeyness * attempting to fix port binding issue * more attempts to fix flakey tests * changelog * fixing import * adding some missing dependencies, but TestService_BroadcastAttestationWithDiscoveryAttempts is still failing * attempting to fix test * reverting test as it migrated to other pr * reverting test * fixing test from merge * Fix `TestService_BroadcastAttestationWithDiscoveryAttempts`. * Fix again `TestService_Start_OnlyStartsOnce`. * fixing TestListenForNewNodes * removing manual set of fulu epoch * missed a few * fixing subnet test * Update beacon-chain/rpc/eth/config/handlers_test.go Co-authored-by: Preston Van Loon <[email protected]> * removing a few more missed spots of reverting fulu epoch setting * updating test name based on feedback * fixing rest apis, they actually need the setting of the epoch due to the guard --------- Co-authored-by: Manu NALEPA <[email protected]> Co-authored-by: Preston Van Loon <[email protected]>

james-prysm and others added 2 commits November 4, 2025 10:29

wip

fc33799

Merge branch 'develop' into fulu-fork-epoch

4a23c5d

james-prysm added the fulu label Nov 4, 2025

james-prysm changed the title ~~Add support for fulu fork epoch~~ Add support for fulu fork epoch and bpo schedule Nov 4, 2025

james-prysm and others added 6 commits November 4, 2025 11:32

fixing tests

2b95811

adding script to update workspace for eth clients

788017d

updating test sepc to 1.6.0 and fixing broadcaster test

f729a6d

fix specrefs

171cfee

more ethspecify fixes

0d7dd55

Merge branch 'develop' into fulu-fork-epoch

39d7744

james-prysm force-pushed the fulu-fork-epoch branch from 1e0c89e to 39d7744 Compare November 4, 2025 20:19

james-prysm added 2 commits November 4, 2025 14:24

still trying to fix ethspecify

dc9c276

fixing attestation tests

26ded24

james-prysm commented Nov 4, 2025

View reviewed changes

Comment thread beacon-chain/das/availability_blobs_test.go

james-prysm commented Nov 4, 2025

View reviewed changes

fixing sha for consensus specs

95add6e

james-prysm marked this pull request as ready for review November 4, 2025 21:37

kasey reviewed Nov 4, 2025

View reviewed changes

james-prysm added 4 commits November 4, 2025 15:59

removing script for now until i have something more standard

2b5fd90

fixing more p2p tests

140d5db

fixing discovery tests

8c701bf

attempting to fix discovery test flakeyness

3c76525

james-prysm commented Nov 5, 2025

View reviewed changes

Comment thread beacon-chain/p2p/discovery_test.go Outdated

james-prysm added 6 commits November 4, 2025 23:19

attempting to fix port binding issue

583df80

more attempts to fix flakey tests

25e8183

Revert "more attempts to fix flakey tests"

9e27746

This reverts commit 25e8183.

Revert "attempting to fix port binding issue"

e3ea37c

This reverts commit 583df80.

Revert "attempting to fix discovery test flakeyness"

c558b65

This reverts commit 3c76525.

Revert "fixing discovery tests"

46f2576

This reverts commit 8c701bf.

james-prysm and others added 8 commits November 5, 2025 08:54

Merge branch 'develop' into fulu-p2p-rpc-test-fixes

0a20e65

attempting to fix test

72ef62a

reverting test as it migrated to other pr

3ecccfb

Merge branch 'develop' into fulu-p2p-rpc-test-fixes

dd0586b

reverting test

19ece61

Merge branch 'develop' into fulu-p2p-rpc-test-fixes

4a743db

fixing test from merge

608a348

Fix TestService_BroadcastAttestationWithDiscoveryAttempts.

e05a5fd

james-prysm and others added 4 commits November 5, 2025 13:11

Merge branch 'develop' into fulu-fork-epoch

86e569f

merging fulu-p2p-rpc-test-fixes tests back in

8f4a60c

Fix again TestService_Start_OnlyStartsOnce.

02059a7

fixing TestListenForNewNodes

4af7dbb

prestonvanloon reviewed Nov 5, 2025

View reviewed changes

james-prysm and others added 6 commits November 5, 2025 15:54

removing manual set of fulu epoch

c7d71a2

missed a few

5110625

fixing subnet test

5f70b23

Update beacon-chain/rpc/eth/config/handlers_test.go

ea42c23

Co-authored-by: Preston Van Loon <[email protected]>

removing a few more missed spots of reverting fulu epoch setting

acff55e

updating test name based on feedback

1ed51ba

james-prysm commented Nov 5, 2025

View reviewed changes

fixing rest apis, they actually need the setting of the epoch due to …

be0f162

…the guard

prestonvanloon approved these changes Nov 5, 2025

View reviewed changes

james-prysm added this pull request to the merge queue Nov 5, 2025

Merged via the queue into develop with commit 8b6f187 Nov 5, 2025
19 checks passed

james-prysm deleted the fulu-fork-epoch branch November 5, 2025 22:49

prestonvanloon mentioned this pull request Nov 6, 2025

Remove test overrides for electra and fulu epochs in beacon-chain/rpc/eth/beacon/handlers_pool_test.go #15988

Merged

3 tasks

		@@ -132,8 +132,8 @@ func TestNextForkData(t *testing.T) {
		{
		name: "after last bpo - should be far future epoch and 0x00000000",

Conversation

james-prysm commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

james-prysm commented Nov 5, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

james-prysm commented Nov 4, 2025 •

edited

Loading