New Vulnerability module for CVE_2025_54589 - #1233
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughAdded a Copyparty CVE-2025-54589 vulnerability module with reflected XSS detection and documented it in the module list. ChangesCopyparty XSS module
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Aarush <cs24b064@smail.iitm.ac.in>
|
@codex review this PR using skill: https://github.com/nettacker-codex-ai/skills/blob/main/pr-review-recommender/SKILL.md |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba72d0421d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| content: | ||
| regex: "</script><script>alert\\(document.domain\\)</script>" |
There was a problem hiding this comment.
Require an HTML response before reporting XSS
When a non-Copyparty endpoint returns 200 and reflects query parameters in a non-executable response such as text/plain or JSON, this content-only condition reports CVE-2025-54589 even though no browser XSS is possible. Add a Content-Type: text/html condition (and ideally a Copyparty-specific fingerprint) before treating the reflected bytes as this vulnerability.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Practically redundant, the regex is unique good enough to detect only the required cve
| ports: | ||
| - 80 | ||
| - 443 |
There was a problem hiding this comment.
Include Copyparty's default port
On a standard Copyparty deployment listening on its default port 3923, a scan with default settings never sends this probe: these candidates contain only 80 and 443, while the repository's default port_scan list also omits 3923, so service discovery cannot find the service and may drop the HTTP payload entirely. Users must know to pass -g 3923; include 3923 in the module and default discovery coverage.
Useful? React with 👍 / 👎.


Proposed change
This PR adds a new vulnerability detection module for CVE-2025-54589, affecting Copyparty.
The vulnerability is a reflected Cross-Site Scripting (XSS) issue caused by improper sanitization of user-controlled input in HTTP query parameters. An unauthenticated attacker can inject arbitrary JavaScript code which is reflected in the server response and executed in the victim’s browser.
The module sends a crafted HTTP GET request containing an XSS payload and determines vulnerability by identifying reflection of the injected payload in the HTML response.
The module has been tested in a local environment against a vulnerable Copyparty instance to verify correct detection behavior.
Type of change
Checklist
make pre-commitand it didn’t generate any changesmake testand all tests passed locallyAdditional notes