Repository navigation
Lock database credentials - #23
Merged
Merged
Conversation
Fix RBAC check for list-target permissions on a given key Tests and docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, database credential sets were not locked to the host that was specified in the agent-side profile.
With this, the server can no longer arbitrarily change the target of a backup job using an agent-side profile to leak the credentials
Might lead to breaking changes, needs a new minor release
Also fixes #20 with a manual confirmation before deleting a key that is in use in historic backups, and patches the hole around listing target names for individual keys