Skip to content

update english name text #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amontenegro merged 1 commit into from
May 29, 2025
Merged

update english name text #2528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/record/components/top-bar/modals/modal-name/modal-name.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ <h2 class="orc-font-body-large">
*ngIf="namesForm?.get('givenNames').hasError('required')"
i18n="@@topBar.firstNameError"
>
Please enter your first/given name
Please enter your given names
</mat-error>
<mat-error
*ngIf="namesForm?.get('givenNames').hasError('illegalName')"
Expand Down Expand Up @@ -146,7 +146,7 @@ <h2 class="orc-font-body-large">
*ngIf="namesForm?.get('familyName').hasError('required')"
i18n="@@topBar.firstNameError"
>
Please enter your first/given name
Please enter your given names
</mat-error>
<mat-error
*ngIf="namesForm?.get('familyName').hasError('illegalName')"
Expand Down
4 changes: 2 additions & 2 deletions src/app/record/components/top-bar/modals/modal-name/modal-name.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ export class ModalNameComponent implements OnInit, OnDestroy {
nameMaxLength = 99
otherNameMaxLength = 254

ngOrcidAddGivenName = $localize`:@@topBar.addGivenName:Add given name`
ngOrcidAddFamilyName = $localize`:@@topBar.addFamilyName:Add family name`
ngOrcidAddGivenName = $localize`:@@topBar.addGivenName:Your given names or forenames`
ngOrcidAddFamilyName = $localize`:@@topBar.addFamilyName:Your family names or surnames`
ngOrcidAddPublishedName = $localize`:@@topBar.addPublishedName:Add a published or credit name`
ngOrcidAddOtherName = $localize`:@@topBar.addOtherName:Add other name`
ngOrcidDefaultVisibilityLabel = $localize`:@@topBar.manageWhoCanSee:Control who can see your given, family and published names by setting the visibility. The default visibility for your names is`
Expand Down
5 changes: 2 additions & 3 deletions src/app/register2/components/form-personal/form-personal.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,8 @@ export class FormPersonalComponent
labelInfoAboutName = $localize`:@@register.ariaLabelInfo:info about names`
labelClose = $localize`:@@register.ariaLabelClose:close`
labelConfirmEmail = $localize`:@@register.confirmEmail:Confirm primary email`
labelNameYouMostCommonly = $localize`:@@register.labelNameYouMostMost:The names you most commonly go by`
labelFamilyNamePlaceholder = $localize`:@@register.familyNamePlaceholder:Your family name or surname
`
labelNameYouMostCommonly = $localize`:@@register.labelNameYouMostMost:Your given names or forenames`
labelFamilyNamePlaceholder = $localize`:@@register.familyNamePlaceholder:Your family names or surnames`
professionalEmail: boolean
personalEmail: boolean
undefinedEmail: boolean
Expand Down
4 changes: 2 additions & 2 deletions src/locale/properties/register/register.en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ register.passwordLetterOrSymbolOk=Password contains at least a letter or symbol
register.passwordNumberError=Password must contain at least a number
register.passwordNumberOk=Password contains at least a number
register.labelConfirmEmail=Confirm your email address
register.labelNameYouMostMost=The names you most commonly go by
register.familyNamePlaceholder=Your family name or surname
register.labelNameYouMostMost=Your given names or forenames
register.familyNamePlaceholder=Your family names or surnames
register.ariaLabelMoreInformationOnVisibility=More information on visibility settings (Opens in new tab)
shared.previousStep=Previous Step
register.addAnAdditionalEmail=Add an additional email
Expand Down
6 changes: 3 additions & 3 deletions src/locale/properties/top-bar/top-bar.en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ topBar.biography=Biography
topBar.publishedName=Published name
topBar.yourPublishedName=Your published name
topBar.alsoKnowAs=Also known as
topBar.addGivenName=Add given name
topBar.addFamilyName=Add family name
topBar.addGivenName=Your given names or forenames
topBar.addFamilyName=Your family names or surnames
topBar.addPublishedName=Add a published or credit name
topBar.addOtherName=Add other name
topBar.information=Information about yourself, your research interests and other pertinent details that enhance your ORCID record.
Expand All @@ -13,7 +13,7 @@ topBar.yourGivenAndFamilyNames=Your given and family names
topBar.orcidHasANumber=ORCID has a number of options for adding and managing your names.
topBar.findOutMore=Find out more about managing names in your ORCID record
topBar.givenNames=Given names
topBar.firstNameError=Please enter your first/given name
topBar.firstNameError=Please enter your given names
topBar.invalidName=Invalid name characters or format
topBar.invalidBio=Invalid characters or format
topBar.familyNames=Family names
Expand Down