fix(csp): add jspreadsheet logo to CSP - #859
Open
MaciekBaron wants to merge 1 commit into
Open
MaciekBaron wants to merge 1 commit into
MaciekBaron wants to merge 1 commit into
Conversation
kevinhowbrook
approved these changes
Oct 1, 2026
Contributor
Contributor
Author
|
@helenb I wonder if this is because the image is referenced using |
Contributor
You're right - just tested in sandbox and the path it reports uses |
helenb
approved these changes
Oct 2, 2026
BJacksonONS
approved these changes
Oct 2, 2026
charlotteromaniuk
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is the context of this PR?
This MR addresses CMS 1336 and adds a URL to the jspreadsheet logo to our CSP, so that it does not get rejected upon loading.
Note even though the ticket uses
http://in the URL, only thehttps://version was added – my understanding is that we shouldn't be loading content over http in any scenario, and therefore the CSP rejecting it is a good thing.How to review
Ensure that tests pass.
Deployment Safety
Bleed and Sandbox deploy automatically on merge, so PRs should be safe to deploy immediately.
Please select one:
Follow-up Actions
Potentially consider only adding this to the CSP when necessary and not on every page load.
Ticket: CMS-1336