Cn 300 send refusal received as a boolean in the case update event and case api responses - #42
Open
onsabdulkalam wants to merge 2 commits into
Conversation
… case API responses Signed-off-by: onsabdulkalam <abdul.abul-kalam@ext.ons.gov.uk>
… case API responses Signed-off-by: onsabdulkalam <abdul.abul-kalam@ext.ons.gov.uk>
onsabdulkalam
added
enhancement
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The event dictionary has the refusalReceived field as a boolean for refused or not. Our case model has this as an enum to capture the different types of refusal, defaulting to null to indicate no refusal.
For the '27 test we have agreed with @david Mort that we will convert and send the refusal field as a boolean in both the CASE_UPDATE event and case API responses, because other teams have been developing to spec in the event dictionary.
What has changed
CASE_UPDATE DTO is modified.
No code refactoring
Test has be modified to adhere and to validate the change
How to test?
make build - shall run successfully
Tested locally
No Automation - not in scope.
Links
https://officefornationalstatistics.atlassian.net/browse/CN-300
Screenshots (if appropriate):