Repository navigation
CN-195 Verify CASE_UPDATE region after sample loading - #31
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are covered by validation with no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Adds acceptance validation for CASE_UPDATE payloads produced during sample loading, including source-row matching and single-character region formatting.
Changes:
- Stores sample rows in Behave context.
- Reuses captured events for detailed payload assertions.
- Documents the
sample_rowscontext attribute.
| File | Description |
|---|---|
CODE_GUIDE.md |
Documents sample_rows. |
acceptance_tests/features/steps/sample_loading.py |
Matches emitted cases to sample rows and validates payload fields and regions. |
acceptance_tests/features/load_sample.feature |
Executes the new CASE_UPDATE validation step. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ravindra-tummuru
approved these changes
Sep 21, 2026
ravindra-tummuru
left a comment
Contributor
There was a problem hiding this comment.
I have removed my comment in favour of future improvement to this scenario as needed. For now I approve it as it is.
sumeetons
deleted the
CN-195-initial-character-region-for-case-update
branch
September 21, 2026 10:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation and Context
Integrated Census services expect the region in outbound
CASE_UPDATEpayloadsto be a single country character even when RM receives and stores a more
specific region code such as
E12000009.What has changed
Sample-load feature
CASE_UPDATEpayloads produced whileloading the existing England sample.
address fields.
leading character of the full sample region.
Step definitions and context
pull and preserving queue cleanup.
sample_rowsin the Behave context index.How to test?
With the local RM topology and Pub/Sub emulator running:
cd census31-rm-acceptance-tests make lint PUBSUB_EMULATOR_HOST=localhost:8538 \ pipenv run behave acceptance_tests/features/load_sample.featureResults: lint passed; 1 feature, 1 scenario, and 2 steps passed.
Links
Screenshots (if appropriate):
N/A