Skip to content

[16.0] [FIX] fs_attachment: prevent 416 on Range requests with X-Accel-Redirect #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
giarve wants to merge 1 commit into from
+8 −0
Closed

[16.0] [FIX] fs_attachment: prevent 416 on Range requests with X-Accel-Redirect #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions fs_attachment/fs_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,14 @@ def get_response(
else:
x_sendfile_path = self.fs_attachment._get_x_sendfile_path()
send_file_kwargs["use_x_sendfile"] = True

# Strip Range header from environ: _send_file("") stats the cwd
# (size=4096 on Linux), causing werkzeug to reject Range requests
# with 416. S3/nginx handle Range natively via X-Accel-Redirect.
environ = dict(send_file_kwargs["environ"])
environ.pop("HTTP_RANGE", None)
send_file_kwargs["environ"] = environ

res = _send_file("", **send_file_kwargs)
# nginx specific headers
res.headers["X-Accel-Redirect"] = x_sendfile_path
Expand Down
Loading