[18.0][FIX] sale_order_type: preserve manual payment term when changing inv…

[lef-adhoc]

…oice journal

When a sale type has no payment_term_id and the user sets a manual term on the sale order, changing the invoice journal triggered a recompute chain (journal_id → company_id → sale_type_id) that caused super() to silently reset invoice_payment_term_id to the partner's default.

Skip the super() call for records where neither the partner nor the sale type changed and the sale type carries no term, so the chosen term is kept. Adds a regression test covering this scenario.

[flotho]

code Review
LGTM

[lef-adhoc]

Hi @pedrobaeza, what do you think about this?

[pedrobaeza]

EDIT: Seeing that it's on moves, not orders. Trying again.

[pedrobaeza]

Still no luck...

[lef-adhoc]

@pedrobaeza Here's a video showing it running on Runboat
https://drive.google.com/file/d/14XV3Vg_VUSRmaDPEtHt-MHmaSL4x6xvQ/view?usp=sharing

[pedrobaeza]

But that's not because of sale_order_type, but the standard that restores the SO payment term.

[lef-adhoc]

@pedrobaeza If you delete the _compute_invoice_payment_term_id method from the sale_order_type, you’ll see that the payment term isn’t updated when you update the journal. You can test this in Odoo’s Runbot.

[pedrobaeza]

For me, the code should be:

Suggested change

	for move in self:
	if move.sale_type_id.payment_term_id:
	move.invoice_payment_term_id = move.sale_type_id.payment_term_id
	else:
	previous_term = previous.get(move)
	if previous_term:
	move.invoice_payment_term_id = previous_term
	for move in self:
	if not move.invoice_payment_term_id and move.sale_type_id.payment_term_id:
	move.invoice_payment_term_id = move.sale_type_id.payment_term_id

[lef-adhoc]

I think this wouldn't solve the issue that motivated the PR.

In this case, after super(), invoice_payment_term_id is already filled with the partner payment term, so your condition would not apply and the manual value would still be lost.

It would also change the current behavior of the module, because sale_order_type would stop overriding the computed payment term and would only act as a fallback when the field is empty.

[nicolascol]

LGTM
https://drive.google.com/file/d/1wDO7Syi-YXBKWLedPjgACvHcyWrq94Up/view
Could you watch the video?
@pedrobaeza