Skip to content

[18.0][FIX] sale_line_name_option: avoid duplicate product name in invoice line#4270

Open
AungKoKoLin1997 wants to merge 1 commit intoOCA:18.0from
qrtl:18.0-fix-sale_line_name_option
Open

[18.0][FIX] sale_line_name_option: avoid duplicate product name in invoice line#4270
AungKoKoLin1997 wants to merge 1 commit intoOCA:18.0from
qrtl:18.0-fix-sale_line_name_option

Conversation

@AungKoKoLin1997
Copy link
Copy Markdown
Contributor

Override _prepare_invoice_line to suppress default_code when the no_product_code_in_sale_line_name option is enabled, preventing the product name from appearing twice in the invoice line description.

@qrtl QT6595

…line

Override _prepare_invoice_line to suppress default_code when the
no_product_code_in_sale_line_name option is enabled, preventing the
product name from appearing twice in the invoice line description.
Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @AungKoKoLin1997, @yostashiro,
some modules you are maintaining are being modified, check this out!

Copy link
Copy Markdown
Contributor

@cgarcia-solvos cgarcia-solvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM!

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants