[18.0][IMP] Add the support for synchronization of other fields from PO lines to supplierinfo, like discount (from module purchase_discount) from #2685#3063
Open
sergioM-S73 wants to merge 1 commit into
Conversation
Contributor
|
Hi @ernestotejeda, |
OCA-git-bot
added
series:18.0
mod:purchase_order_supplierinfo_update
sergioM-S73
force-pushed
the
18.0-mig-pr-2685
branch
3 times, most recently
from
07bcc5f to
5f83706
Compare
legalsylvain
approved these changes
May 14, 2026
Contributor
legalsylvain
left a comment
legalsylvain
left a comment
There was a problem hiding this comment.
nitpicking inline.
otherwise, LGTM. Thanks for the forward port !
Comment on lines
+81
to
+85
| triple_discount = "triple.discount.mixin" in self.env | ||
| sync_fields = ["discount"] | ||
| if triple_discount: | ||
| sync_fields += ["discount1", "discount2", "discount3"] | ||
| return sync_fields |
Contributor
There was a problem hiding this comment.
Suggested change
| triple_discount = "triple.discount.mixin" in self.env | |
| sync_fields = ["discount"] | |
| if triple_discount: | |
| sync_fields += ["discount1", "discount2", "discount3"] | |
| return sync_fields | |
| sync_fields = ["discount"] | |
| if "triple.discount.mixin" in self.env: | |
| sync_fields += ["discount1", "discount2", "discount3"] | |
| return sync_fields |
…PO lines to supplierinfo, like discount (from module purchase_discount) from OCA#2685
sergioM-S73
force-pushed
the
18.0-mig-pr-2685
branch
from
5f83706 to
a8541a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a forward-port of #2685 from v16 to v18.0
The original commits have been squashed into a single commit to maintain a clean history. The code has also been adapted to work with the Odoo 18.0 API and the recent structural changes of the module in this version.
Original PR: #2685