Skip to content

[19.0][MIG] purchase_order_line_description#3061

Open
Shide wants to merge 16 commits into
OCA:19.0from
moduon:19.0-mig-purchase_order_line_description
Open

[19.0][MIG] purchase_order_line_description#3061
Shide wants to merge 16 commits into
OCA:19.0from
moduon:19.0-mig-purchase_order_line_description

Conversation

@Shide
Copy link
Copy Markdown
Contributor

@Shide Shide commented May 12, 2026

Straight forward migration

image

MT-14424 @moduon @EmilioPascual @chienandalu @fcvalgar @Gelojr please review if you want 😄

tafaRU and others added 16 commits May 12, 2026 13:01
Currently translated at 100.0% (7 of 7 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_description/pt_BR/
Currently translated at 100.0% (7 of 7 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_description/sl/
Installing this module introduces a regression from Odoo core when the supplier speaks a different language than the user, setting the description on the user's lang instead.

@Tecnativa TT27390
Currently translated at 100.0% (7 of 7 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_description/pt_BR/
Currently translated at 42.8% (3 of 7 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_line_description/it/
Currently translated at 100.0% (7 of 7 strings)

Translation: purchase-workflow-18.0/purchase-workflow-18.0-purchase_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-18-0/purchase-workflow-18-0-purchase_order_line_description/it/
Currently translated at 85.7% (6 of 7 strings)

Translation: purchase-workflow-18.0/purchase-workflow-18.0-purchase_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-18-0/purchase-workflow-18-0-purchase_order_line_description/es/
Currently translated at 100.0% (7 of 7 strings)

Translation: purchase-workflow-18.0/purchase-workflow-18.0-purchase_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-18-0/purchase-workflow-18-0-purchase_order_line_description/es/
@OCA-git-bot OCA-git-bot added series:19.0 mod:purchase_order_line_description Module purchase_order_line_description labels May 12, 2026
Copy link
Copy Markdown
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Copy Markdown
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @Shide

Functional and code review

Copy link
Copy Markdown

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Shide on this migration. The module is simple, focused, and the behavior is correctly preserved for purchase order line descriptions.

I have performed the following functional tests:
Test 1: OK - A product with a purchase description correctly uses only that purchase description on the purchase order line.
Test 2: OK - A product without purchase description keeps the standard Odoo behavior and the purchase order line is created without errors.
Test 3: OK - Changing the product on an existing purchase order line correctly recomputes the line description.
Test 4: OK - The purchase description is correctly translated according to the vendor language when a translation exists.
Test 5: OK - The purchase order can be confirmed without errors and the line description is preserved.
Test 6: OK - The printed purchase order shows the expected purchase description on the product line.
Test 7: OK - The user can manually edit the purchase order line description after it has been automatically filled.

Based on these tests, the PR works as expected for the reviewed functional scope.

Image

@HviorForgeFlow
Copy link
Copy Markdown
Member

/ocabot merge nobump

@Shide
Copy link
Copy Markdown
Contributor Author

Shide commented May 14, 2026

/ocabot merge nobump

Doesn't work 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.