[14.0][FIX] purchase_operating_unit: allow manager to select OUs#852
Merged
Conversation
Checking the field user_ids of operating.unit to set a domain is both unnecessary (record rules already filter the correct records) and wrong/obsolete because users who are managers of all OUs don't appear in the user_ids field.
OCA-git-bot
added
series:14.0
mod:purchase_operating_unit
Contributor
|
no need to FWP /ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
It looks like something changed on |
Contributor
|
Congratulations, your PR was merged at 8f79f40. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking the field user_ids of operating.unit to set a domain is both unnecessary (record rules already filter the correct records) and wrong/obsolete because users who are managers of all OUs don't appear in the user_ids field.
Cf. the same fix in #850