[18.0][IMP] apriori: sale_commission_product_criteria_semaphore -> sale_commission_oca_product_criteria_semaphore#5577
Open
CarlosRoca13 wants to merge 2 commits intoOCA:18.0from
Conversation
Contributor
|
Can you also add |
Author
|
Sure |
…mission_oca_product_criteria_semaphore
…a_product_criteria
CarlosRoca13
force-pushed
the
18.0-imp-sale_commission_product_criteria_semaphore
branch
from
cc9a09d to
235ae25
Compare
Author
david-banon-tecnativa
approved these changes
Apr 6, 2026
Contributor
david-banon-tecnativa
left a comment
david-banon-tecnativa
left a comment
There was a problem hiding this comment.
LGTM I don't think the test failures are related to this PR
Member
|
The idea behind the |
Member
|
As the module is merged, let's keep it as is. |
pedrobaeza
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT61696
This PR depends of:
ping @pedrobaeza @david-banon-tecnativa