Skip to content

fix(site): keep comparison content on the newest selection - #109

Open
rudycelekli wants to merge 1 commit into
Nutlope:mainfrom
rudycelekli:fix/comparison-latest-selection-20261030
Open

rudycelekli wants to merge 1 commit into
Nutlope:mainfrom
rudycelekli:fix/comparison-latest-selection-20261030

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Summary

Keep the comparison images and issue counts synchronized with the newest selected tab when image loads complete out of order. Currently a slow earlier pair can replace a newer pair after it has loaded; an earlier image decode can also remove the newer selection's transition state.

Give each selection a generation and ignore stale loading/decoding callbacks. Clear any existing animation class when the next selection uses reduced motion. Pair caching, normal selection and circular page-scroll behavior are unchanged. Add the regression to the existing verification workflow without changing its three current gates.

Validation

  • The same seven tests have five failures and two controls passing on unchanged current upstream; the fix passes all seven. The existing LF/CRLF regression also passes: eight tests total.
  • Tests execute the actual production script in Node VM with controlled DOM, image completion and decode boundaries. Cases cover out-of-order loads in both motion modes, stale decode completion, cached/sequential picks, and changes of motion preference during pending loads/decodes. No real-browser or visual validation is claimed.
  • 101 reference files clean; all 50 themes validate; regenerated index unchanged; whitespace checks pass.
  • Based on 4f6a46c; tested tree 442e234bc1f659fcf619633622580faa69b3f0b4. Hosted CI pending.

Prepared with AI assistance under the account owner's explicit direction and independently reviewed by another AI agent. Review found a motion-preference edge, which is included in this fix and regression. Maintainer review and acceptance remain pending.

Ignore obsolete image-load and decode callbacks after another tab is selected. Clear the prior animation when reduced motion is chosen and exercise controlled completion ordering in CI.
@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

@rudycelekli is attempting to deploy a commit to the Together AI Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant