Repository navigation
fix(site): keep comparison content on the newest selection - #109
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Ignore obsolete image-load and decode callbacks after another tab is selected. Clear the prior animation when reduced motion is chosen and exercise controlled completion ordering in CI.
|
@rudycelekli is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the comparison images and issue counts synchronized with the newest selected tab when image loads complete out of order. Currently a slow earlier pair can replace a newer pair after it has loaded; an earlier image decode can also remove the newer selection's transition state.
Give each selection a generation and ignore stale loading/decoding callbacks. Clear any existing animation class when the next selection uses reduced motion. Pair caching, normal selection and circular page-scroll behavior are unchanged. Add the regression to the existing verification workflow without changing its three current gates.
Validation
Prepared with AI assistance under the account owner's explicit direction and independently reviewed by another AI agent. Review found a motion-preference edge, which is included in this fix and regression. Maintainer review and acceptance remain pending.