Skip to content

fix(theme): reject invalid hue values before reporting clearance - #108

Open
rudycelekli wants to merge 1 commit into
Nutlope:mainfrom
rudycelekli:fix/finite-hue-check-20261029
Open

rudycelekli wants to merge 1 commit into
Nutlope:mainfrom
rudycelekli:fix/finite-hue-check-20261029

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Summary

Reject invalid hue arguments before claiming a custom accent is clear of the theme catalog. Currently theme.mjs check --hue NaN exits successfully with a clear verdict because every hue comparison is false. Empty values become zero, and a missing hue can be silently dropped when another option follows.

Require a non-empty finite angle and exit 2 otherwise. Keep circular comparisons (30, 390 and -330 degrees match identically) and face-only checks. Add the CLI regression to the existing verification workflow alongside its three unchanged gates.

Validation

  • Same five CLI tests on current upstream: three failures, two controls pass. With this fix all five pass. The existing LF/CRLF theme regression also passes: six tests total.
  • Actual CLI subprocesses and actual catalog, no mocks, browser or provider.
  • 101 reference files clean; all 50 themes validate; regenerated index unchanged; whitespace checks pass.
  • Based on 4f6a46c; tested tree 19bcf4d0fe0821122337036a346ed262808c9eb1. Hosted CI pending.

Prepared with AI assistance under the account owner's explicit direction and independently reviewed by another AI agent. Maintainer review and acceptance remain pending.

Reject invalid, empty or missing hue arguments before catalog comparison. Preserve circular hue matching and face-only checks, with CLI regressions in the existing verification workflow.
@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

@rudycelekli is attempting to deploy a commit to the Together AI Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant