Repository navigation
fix(theme): reject invalid hue values before reporting clearance - #108
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Reject invalid, empty or missing hue arguments before catalog comparison. Preserve circular hue matching and face-only checks, with CLI regressions in the existing verification workflow.
|
@rudycelekli is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject invalid hue arguments before claiming a custom accent is clear of the theme catalog. Currently
theme.mjs check --hue NaNexits successfully with a clear verdict because every hue comparison is false. Empty values become zero, and a missing hue can be silently dropped when another option follows.Require a non-empty finite angle and exit 2 otherwise. Keep circular comparisons (30, 390 and -330 degrees match identically) and face-only checks. Add the CLI regression to the existing verification workflow alongside its three unchanged gates.
Validation
Prepared with AI assistance under the account owner's explicit direction and independently reviewed by another AI agent. Maintainer review and acceptance remain pending.