Repository navigation
Conversation
|
@bryan is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106.
sloplint . dist --jsoncan report a clean result without scanningdist, whilesloplint dist . --jsonfinds its violations. The same argument-order regression affectsbuildandcoverage.The realpath guard added in #103 marks implicitly skipped build directories as visited. Move the existing directory-exclusion check before that guard, so only eligible paths enter
seen. The guard still runs before recursion, preserving the cycle/alias fix by @xunguangzlj-cloud.Add a ten-case regression to the existing
refcheck.mjsrunner: parent-only traversal, each explicit build target, and both argument orders. It checks file counts, findings and exit statuses. The existing symlink-cycle fixture remains unchanged.Verification
node skills/hallmark/scripts/refcheck.mjs: clean across 101 reference files, including the new regression and existing symlink fixture.node --test skills/hallmark/scripts/theme.test.mjs: one test passes.git diff --check: passes.Locally verified on macOS with Node 24.14.1. Browser/render integration was not run; no lint rules or dependencies change. Hosted CI is pending.
Prepared with AI assistance and independently checked by a second agent against the final diff and real CLI. This is not a claim of human review; maintainer review remains pending.