Skip to content

CompatHelper: bump compat for OrdinaryDiffEqRosenbrock to 2 for package benchmark, (keep existing compat)#301

Closed
github-actions[bot] wants to merge 1 commit intomainfrom
compathelper/new_version/2026-04-27-01-03-51-545-01770896495
Closed

CompatHelper: bump compat for OrdinaryDiffEqRosenbrock to 2 for package benchmark, (keep existing compat)#301
github-actions[bot] wants to merge 1 commit intomainfrom
compathelper/new_version/2026-04-27-01-03-51-545-01770896495

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This pull request changes the compat entry for the OrdinaryDiffEqRosenbrock package from 1.3 to 1.3, 2 for package benchmark.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@JoshuaLampert JoshuaLampert force-pushed the compathelper/new_version/2026-04-27-01-03-51-545-01770896495 branch from 79d28b4 to 003fdab Compare April 27, 2026 01:03
@github-actions
Copy link
Copy Markdown
Contributor Author

Benchmark Results (Julia v1.10)

Time benchmarks
main 003fdab... main / 003fdab...
bbm_1d/bbm_1d_basic.jl - rhs!: 14.6 ± 1.1 μs 13.2 ± 1.2 μs 1.11 ± 0.13
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.248 ± 0.0073 ms 0.248 ± 0.0071 ms 1 ± 0.041
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0874 ± 0.0058 ms 0.0851 ± 0.0033 ms 1.03 ± 0.079
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0322 ± 0.0017 ms 0.033 ± 0.0019 ms 0.978 ± 0.076
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 26.5 ± 1.8 μs 26.4 ± 2.1 μs 1.01 ± 0.11
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0331 ± 0.0029 ms 0.0333 ± 0.0025 ms 0.995 ± 0.11
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 5.72 ± 0.2 μs 5.63 ± 0.051 μs 1.02 ± 0.036
kdv_1d/kdv_1d_basic.jl - rhs!: 1.74 ± 0.077 μs 1.92 ± 0.066 μs 0.904 ± 0.051
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.69 ± 0.056 μs 2.25 ± 0.14 μs 0.753 ± 0.054
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.215 ± 0.016 ms 0.214 ± 0.016 ms 1.01 ± 0.11
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.161 ± 0.0097 ms 0.159 ± 0.0098 ms 1.02 ± 0.088
time_to_load 2.33 ± 0.015 s 2.32 ± 0.03 s 1.01 ± 0.015
Memory benchmarks
main 003fdab... main / 003fdab...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be done in #291.

@ranocha ranocha closed this in #291 May 1, 2026
@ranocha ranocha deleted the compathelper/new_version/2026-04-27-01-03-51-545-01770896495 branch May 1, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant