Repository navigation
Fix residual surface water blocking rainfall infiltration - #217
Merged
bgroenks96 merged 2 commits intoOct 9, 2026
Merged
Conversation
bgroenks96
approved these changes
Oct 9, 2026
Collaborator
|
Thanks @yunan-l! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tiny positive surface-water pool can remain after its drainage rate rounds to zero.
DirectSurfaceRunoffthen uses that zero drainage rate to calculate infiltration, sending new rainfall to runoff even when the soil is unsaturated.Fix
Treat a pool at or below
eps(NF)as negligible when choosing how rainfall infiltrates. Its remaining drainage is still included in the runoff calculation. Larger surface-water pools keep their existing behavior.