Repository navigation
Add single pool soil carbon/biogeochemistry process - continuation of #55 - #215
Merged
Merged
Conversation
- added boundary conditions for litter inputs - changed parameter values - Fixed Diffusion sign
Contributor
Author
|
Now it all looks good with docs. That rebase was a pain. |
bgroenks96
reviewed
Oct 8, 2026
bgroenks96
left a comment
bgroenks96
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks for the changes! I guess the main questions are just how much work is outstanding on the transport equations.
Collaborator
Sorry about that! The PR got a bit stale, I guess. |
bgroenks96
approved these changes
Oct 9, 2026
Collaborator
|
Thanks @Qfl3x and @BernhardAhrens! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #55.
The model has been stabilized. With one caveat: Thermodynamics and Soil Organic Carbon (SOC) operate on different timescales, with Thermodynamics being much smaller. So the timestep has to follow the thermodynamics model limitation, and the model has to run long enough for SOC to actually change.
Few key changes from original PR: