Skip to content

Add rectangular-wind WW3 validation cases (7 test cases)#23

Draft
mochell wants to merge 1 commit into
mainfrom
rectangular-wind-validation
Draft

Add rectangular-wind WW3 validation cases (7 test cases)#23
mochell wants to merge 1 commit into
mainfrom
rectangular-wind-validation

Conversation

@mochell

@mochell mochell commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Added 7 test cases of static wind problems.

  • gridded_wind.jl: GriddedWind struct with trilinear (x,y,t) interpolation, extending Ripple.wind_speed / wind_angle for use with PressureCorrelationInput
  • run_ripple.jl: runs all 7 cases on a 51×51 physical grid with PrecomputedSources (ST3-equivalent physics + DIA), LowStorageRK3, CFL-limited dt; writes hourly Hs(x,y,t) NetCDF output
  • compare.jl: loads Ripple + WW3 reference, computes spatial-mean Hs time series, plots per-case time series and final-time heatmaps, prints RMSE/bias table

Summary

Validation

  • may move to examples or tests
  • julia --startup-file=no --project=. test/runtests.jl
  • Updated examples, docs, or validation cases if behavior changed
  • Preserved exact finite-volume spectral integration
  • Preserved nothing semantics for absent model components

Optional Gates

  • Not needed
  • Required and documented in the PR

Moves wind input and WW3 reference data from the untracked data_folder/
into validation/rectangular_wind_ww3/data/{wind,reference}/. Adds three
scripts:

- gridded_wind.jl: GriddedWind struct with trilinear (x,y,t) interpolation,
  extending Ripple.wind_speed / wind_angle for use with PressureCorrelationInput
- run_ripple.jl: runs all 7 cases on a 51×51 physical grid with PrecomputedSources
  (ST3-equivalent physics + DIA), LowStorageRK3, CFL-limited dt; writes hourly
  Hs(x,y,t) NetCDF output
- compare.jl: loads Ripple + WW3 reference, computes spatial-mean Hs time series,
  plots per-case time series and final-time heatmaps, prints RMSE/bias table

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mochell
mochell marked this pull request as draft May 20, 2026 14:41
@glwagner

Copy link
Copy Markdown
Member

Nice!

We don't want to add these .nc files to the repo. This will inflate the repo size. We should add them to another repo, say RippleArtifacts, and download them inside the scripts.

@mochell

mochell commented May 20, 2026

Copy link
Copy Markdown
Collaborator Author

Let's call them WaveArtifacts or RipPiclesArtifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants