Repository navigation
docs(terraform): tell collector-cutover instructions to stop the collector first - #94
Closed
tim-thacker-nullify wants to merge 1 commit into
Closed
tim-thacker-nullify wants to merge 1 commit into
tim-thacker-nullify wants to merge 1 commit into
Conversation
…ector first collector_cluster_arns docs told users to override the guard during a collector-to-managed-scan cutover but never said to disable the collector first, so following them literally leaves the collector uploading while the cluster also gets managed-scan access -- the duplicate registration the guard exists to prevent. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tim-thacker-nullify
added a commit
that referenced
this pull request
Sep 15, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final docs fix on the terraform review chain (converged per round-6 review).
collector_cluster_arnsoverride docs told users to set it "so the guard stops blocking it" during a collector-to-managed-scan cutover, but never said to disable or remove the in-cluster collector first. Followed literally, the cluster gets managed-scan access while the collector CronJob keeps uploading, duplicating the cluster in inventory -- the exact case the guard exists to prevent. Added one clause at each site:aws-integration-setup/terraform/variables.tf:119,aws-integration-setup/terraform-v6/variables.tf:113,aws-integration-setup/terraform/README.md:190,aws-integration-setup/terraform-v6/README.md:111.Merge order:
main ← #78 ← #81 ← #83 ← #89 ← #91 ← #92 ← #93 ← this PR.The reviewer judged the chain converged as of round 6; remaining LOWs (N3-N8 in the review report) are deferred to a follow-up rather than another round on this stack.
#82 and #88 should be closed before this stack merges: #82 conflicts in both
k8s-resources/variables.tffiles, and #88 merges cleanly but leaves duplicate README paragraphs.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.