Repository navigation
fix(aws): let the managed EKS scan list CronJobs - #109
Draft
tim-thacker-nullify wants to merge 2 commits into
Draft
tim-thacker-nullify wants to merge 2 commits into
tim-thacker-nullify wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ation docs Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The managed EKS scan's
nullify-readonlyClusterRole grantsjobsbut notcronjobs, so managed-scanned clusters never report CronJobs; the collector records the Forbidden as an allowed coverage gap and the cloud graph has no CronJob workloads to attribute scheduled Job pods to.Add
cronjobs.batchtoRBAC_RESOURCESinsetup-eks-managed-scan.sh.managed_scan.tf(terraform and terraform-v6) grantsbatchjobsandcronjobs,listonly; module tests updated.README RBAC table and "Kinds read" cell updated; a stale comment about
jobsbeing granted ahead of a monorepo stack removed.Module tests now count 27 managed-scan kinds; the CloudFormation README table and verify text say 27 and list
cronjobs.Existing managed-scan customers pick this up by re-running
applyor the script; until then the cronjobsForbiddenis recorded as a coverage gap. Open #107 adds a readonly manifest and chart granting batchjobsonly: it needscronjobstoo (or a rebase after this), otherwisesetup-eks-managed-scan.shverify fails oncronjobs.batch.🤖 Generated with Claude Code