Repository navigation
fix(terraform): bring #58 into #78, fix the red tftest and correct the managed-scan README - #102
Merged
tim-thacker-nullify merged 5 commits intoSep 15, 2026
Conversation
whiskeylotus's review on #58 (W58-2) flagged that the collector ClusterRole grants 12 kinds main's collect.go never lists: jobs is kept since the monorepo's fix/k8s-deployment-matching-review stack (#12807, which #12830 sits on) starts collecting Jobs owned by a CronJob; cronjobs, horizontalpodautoscalers, poddisruptionbudgets, ingressclasses, storageclasses, csidrivers, runtimeclasses, priorityclasses, flowschemas, certificatesigningrequests and customresourcedefinitions are dropped -- no open collector change reads any of them. Verified against context/internal/cloudintegrations/k8sintegration/ collect/collect.go on both the monorepo's main and fix/k8s-deployment-matching-review branches. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
#99 dropped the 11 never-collected kinds (cronjobs, HPA, PDB, ingressclasses, storageclasses, csidrivers, runtimeclasses, priorityclasses, flowschemas, certificatesigningrequests, CRDs) from the Helm ClusterRole only. The Terraform collector roles in both trees still granted them, so a k8s-resources install of #58 kept read access to kinds no collector reads, and the two collector roles differed by those 11 kinds. jobs is kept. Helm (0.3.0), TF v5 and TF v6 now grant identical kinds and verbs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rraform collector roles) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
- Resolve k8s-resources main.tf with #78's side: it adds enable_collector gating, preconditions and CLUSTER_NAME; the collector role rules equal #58's. - Take #58's chart clusterrole.yaml byte-for-byte so both branches carry the same chart 0.4.0 bytes (the publish check rejects same-version drift). - From #100: whole-statement IAM drift check, scripts/** path filter, and the access-analyzer:List* tftest assertion that #78 currently fails. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…s in managed-scan RBAC - Drop the server-side Table fetch claim and the per-cluster opt-out claim: neither exists in the deployed collector or managed scan. - Kinds-read row: identical from k8s-resources and chart 0.3.0; 0.2.0 grants extra kinds. - Add the batch/jobs row managed_scan.tf already grants. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 15, 2026
tim-thacker-nullify
merged commit Sep 15, 2026
ea9b305
into
fix/terraform-kms-image-region
30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#100 was built on #98's pre-squash head and can't merge into the moved #78 (duplicate
batch/jobs, 9 rules, red tftest). This rebuilds its surviving fixes on #78 (5e171a6) and fixes the round-2 findings.dc6abe9, now including fix(terraform): finish W58-2 in Terraform and correct #99's W58-4 #101) into fix(aws): grant KMS key/* for alias ARNs, pin the collector image and look up clusters in their own region #78.k8s-resources/main.tfkeeps fix(aws): grant KMS key/* for alias ARNs, pin the collector image and look up clusters in their own region #78's side (enable_collectorgating, preconditions,CLUSTER_NAME); its collector role rules equal feat: grant wafv2:Get*, ec2:GetEbsEncryptionByDefault and the missing Kubernetes list kinds #58's.clusterrole.yamltaken byte-for-byte from feat: grant wafv2:Get*, ec2:GetEbsEncryptionByDefault and the missing Kubernetes list kinds #58, so both branches carry identical chart 0.4.0 bytes; fix(helm): publish every chart version instead of replacing the Pages site #60's publish check rejects same-version content drift (O2).not_actions;scripts/**path filter; tftest assertsaccess-analyzer:List*, which fixes fix(aws): grant KMS key/* for alias ARNs, pin the collector image and look up clusters in their own region #78's current rednullify-aws-integrationtests (O1).batch | jobsrowmanaged_scan.tfalready grants (F4).Supersedes #100. Chart 0.2.0 bytes unchanged. Report: round2-connector-98-99.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.