fix(pgwire): answer a real class for the arm-less error variants - #361
Merged
Merged
Conversation
The blanket INTERNAL_ERROR fallback in error_to_sqlstate flattened 65 of the 101 crate::Error variants, so a statement reading a balance, hitting a period lock, a legal hold, a retention floor, a type guard, or a mirror write got XX000 while the crate's classify() map already carried the class. The fallback now borrows it through classify() and answers from the same numeric table the remote path reads. The bridge exposed one arm doing harm: RetryableSchemaChanged classified as a plan error, which reads as 'fix your SQL' for a condition the lease paths retry. It now classifies as a write conflict (40001), matching its contract.
EnRaiha
added
the
run-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folded into #359: the fallback bridge is the same table's completion, so it ships in the mapper PR instead of a stacked one.