Conversation
…tup] Both readiness bounds were hard-coded constants after the config fields were dropped. raft_ready_timeout_ms (300 s) and data_group_recovery_timeout_ms (600 s) now live under [tuning.startup], keeping the values that survived the backlogged recoveries as defaults. A bound still written under [server] is rejected at load with the moved-to path named.
EnRaiha
added
the
run-ci
EnRaiha
added this pull request to stack #358
September 20, 2026 11:14
EnRaiha
added
run-ci
Member
|
Closing: targets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Both readiness bounds became hard-coded constants when their
[server]fields were removed. Production had carrieddata_group_recovery_timeout_ms = 600000, and the tighter constants aborted a backlogged start withmetadata group applied no entry for 30s/data raft group recovery timeout after 60sinstead of waiting the recovery out.What
[tuning.startup] raft_ready_timeout_ms[server] raft_ready_timeout_ms(removed)[tuning.startup] data_group_recovery_timeout_ms[server] data_group_recovery_timeout_ms(removed)StartupTuninglives beside the other tuning tables innodedb-types;main.rsthreads both bounds intoawait_cluster_ready, which passes them towait_for_raft_readyandawait_data_group_recovery.[server]fails the load with the moved-to path named.from_filechecks the parsed table before deserialization, so serde's generic unknown-field list never surfaces for these two keys.docs/getting-started.mddocuments the section.How to test
defaults_are_five_and_ten_minutes,both_bounds_take_overrides(nodedb-types)from_file_rejects_a_startup_bound_at_its_old_server_path,from_file_rejects_the_legacy_data_group_recovery_bound,from_file_reads_the_startup_bounds_from_tuningcargo test -p nodedb --lib bootstrap::— 45 pass;from_file_config tests — 10 passNotes
fix/calvin-backpressureand retargets to main when fix(cluster): treat a full dispatch queue as retryable capacity and pace the startup rebuild #355 merges.NODEDB_*env override yet; the config file is the only source.Fixes #354
Tradeoffs
Tradeoff: the two bounds have no
NODEDB_*env override yet — the config file is the only source, matching the field's pre-removal shape.