Skip to content

Add 'user_approval' submodule#577

Closed
iTakeshi wants to merge 6 commits into
NoamB:masterfrom
iTakeshi:user_approval
Closed

Add 'user_approval' submodule#577
iTakeshi wants to merge 6 commits into
NoamB:masterfrom
iTakeshi:user_approval

Conversation

@iTakeshi

Copy link
Copy Markdown
Contributor

This PR adds a new submodule feature 'usre_approval'.
Using this submodule, you can require new registrants to be approved by
existing users (especially by an administrator team, I suppose).

Although Sorcery already has a feature named 'user_activation' and the
submodule has very similar function to 'user_approval',
'user_activation' intends to require new registrants to activate their
accounts themselves.
As contrasted, 'user_approval' intends to enable the admin team to
decide whether they accept the new registrant at the website.

iTakeshi added 4 commits July 12, 2014 01:08
This commit adds a new submodule feature 'usre_approval'.
Using this submodule, you can require new registrants to be approved by
existing users (especially by an administrator team, I suppose).

Although Sorcery already has a feature named 'user_activation' and the
submodule has very similar function to 'user_approval',
'user_activation' intends to require new registrants to activate their
accounts themselves.
As contrasted, 'user_approval' intends to enable the admin team to
decide whether they accept the new registrant at the website.
@arnvald

arnvald commented Jul 14, 2014

Copy link
Copy Markdown
Collaborator

Hi @iTakeshi

thanks for your PR 💙
There's similar situation as in #535 - I'm not sure if this should be part of the core gem, or should be available as a plugin. I'm working on making Sorcery easy to extend by external gems and maybe it will be better to release it separately.
However, I'm not sure yet how it will work out, so I'm leaving this PR open and I'll let you know as soon as we decide about what to keep in the core and what to have as external plugins

@iTakeshi

Copy link
Copy Markdown
Contributor Author

Hi @arnvald

👍 for your plan to introduce a pluggable architecture and I believe this make the gem more awesome!

@iTakeshi iTakeshi closed this Jun 26, 2020
@iTakeshi iTakeshi deleted the user_approval branch June 26, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants