lib/services: move portable service infrastructure out of nixos/ - #506519
Conversation
Move the portable modular service base from nixos/modules/system/service/portable/ to lib/services/, making it importable by any module system (home-manager, nix-darwin) without reaching into the nixos/ tree. Moved files: service.nix, lib.nix, config-data.nix, config-data-item.nix, test.nix. All external references updated (systemd/system.nix, doc/manual/default.nix, assertions.nix, README.md). No functional changes - only import paths differ.
Include the moved-out modular service infrastructure into the set of files to evaluate during the docs build. This was previously unnecessary because even the portable parts were stored inside the nixos tree.
4c8665d to
1baf57f
Compare
|
Not sure if this should go into Maybe we should actually carry out the division into multiple "libs" that better reflects the purposes and maintenance models for these things.
Still inclined to merge as that could be figured out and agreed upon later. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2913 |
There was a problem hiding this comment.
I agree with @roberth, However this can be argued later. Apart from that, the rest LGTM/SGTM.
|
It would also be nice if we have a proper attribute to reference for |
This is probably best done in a followup pr, as this seems to be a nitpick more than of a merge blocker. |
Followup to NixOS#506519. Adds `lib.services` so consumers can reference the portable service infrastructure directly instead of using fragile relative path imports.
opened #507052 now for this. |
…astructure `inputs.nixpkgs` is here updated to the latest commit of the PR introducing the change: NixOS/nixpkgs#506519
nixpkgs PR: NixOS/nixpkgs#506519 Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
nixpkgs PR: NixOS/nixpkgs#506519 Co-Authored-By: Luke Bailey <baileylu@tcd.ie> Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
nixpkgs PR: NixOS/nixpkgs#506519 Co-Authored-By: Luke Bailey <baileylu@tcd.ie> Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
nixpkgs PR: NixOS/nixpkgs#506519 Co-Authored-By: Luke Bailey <baileylu@tcd.ie> Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
nixpkgs PR: NixOS/nixpkgs#506519 Co-Authored-By: Luke Bailey <baileylu@tcd.ie> Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
nixpkgs PR: NixOS/nixpkgs#506519 Co-Authored-By: Luke Bailey <baileylu@tcd.ie> Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Update nixpkgs version and fix portable-lib path changed in NixOS/nixpkgs#506519.
Followup to NixOS#506519. Adds `lib.services` so consumers can reference the portable service infrastructure directly instead of using fragile relative path imports.
Followup to NixOS#506519. Adds `lib.services` so consumers can reference the portable service infrastructure directly instead of using fragile relative path imports.
Followup to NixOS#506519. Adds `lib.services` so consumers can reference the portable service infrastructure directly instead of using fragile relative path imports.
Followup to NixOS#506519. Adds `lib.services` so consumers can reference the portable service infrastructure directly instead of using fragile relative path imports.
Followup to NixOS#506519. Adds `lib.services` so consumers can reference the portable service infrastructure directly instead of using fragile relative path imports.
Followup to NixOS#506519. Adds `lib.services` so consumers can reference the portable service infrastructure directly instead of using fragile relative path imports.
Followup to NixOS#506519. Adds `lib.services` so consumers can reference the portable service infrastructure directly instead of using fragile relative path imports.
Move the portable modular service base from
nixos/modules/system/service/portable/tolib/services/, making it importable by any module system (home-manager, nix-darwin, ...) without reaching into the nixos/ tree, given this should not actually depend on NixOS.No functional changes - only import paths differ.
Precursor to #506343.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.