Skip to content

[Revert]: "nixos/traefik: refactor" due to issues with complex configurations and failing testcases. - #490920

Merged
SigmaSquadron merged 1 commit into
masterfrom
revert-482512-push-lysqxmrwmzlt
Feb 16, 2026
Merged

[Revert]: "nixos/traefik: refactor" due to issues with complex configurations and failing testcases.#490920
SigmaSquadron merged 1 commit into
masterfrom
revert-482512-push-lysqxmrwmzlt

Conversation

@SigmaSquadron

@SigmaSquadron SigmaSquadron commented Feb 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #482512
Closes #490814

  • nixosTests.traefik passes

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation labels Feb 16, 2026
@SigmaSquadron

SigmaSquadron commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 490920 --additional-package nixosTests.traefik
Commit: b898b53e2c0ade92cfcaab4beb088b67bd66831a

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 test built:
  • nixosTests.traefik

@SigmaSquadron
SigmaSquadron merged commit c1e0f60 into master Feb 16, 2026
34 of 38 checks passed
@SigmaSquadron
SigmaSquadron deleted the revert-482512-push-lysqxmrwmzlt branch February 16, 2026 02:49
@SigmaSquadron
SigmaSquadron restored the revert-482512-push-lysqxmrwmzlt branch February 16, 2026 02:49
@SigmaSquadron
SigmaSquadron deleted the revert-482512-push-lysqxmrwmzlt branch February 16, 2026 02:49
@jackrosenberg jackrosenberg mentioned this pull request Feb 16, 2026
Open
3 tasks
@ulrikstrid

ulrikstrid commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This is very annoying since I spent quite some time to migrate this (especially finding the bug that this revert is trying to fix), and now we're breaking things again. I assume I'll have to re-revert things on my end again soon.

I understand that I'm on unstable but going back and forth is not normal.

edit: Even when reverting my changes my Treafik setup is still broken since this revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SigmaSquadron @ulrikstrid