Skip to content

ocamlPackages.wasm_of_ocaml-compiler: init at 6.0.1#384029

Merged
vbgl merged 1 commit into
NixOS:masterfrom
stepbrobd:wasm_of_ocaml
Feb 24, 2025
Merged

ocamlPackages.wasm_of_ocaml-compiler: init at 6.0.1#384029
vbgl merged 1 commit into
NixOS:masterfrom
stepbrobd:wasm_of_ocaml

Conversation

@stepbrobd
Copy link
Copy Markdown
Member

@stepbrobd stepbrobd commented Feb 21, 2025

wasm_of_ocaml-compiler was merged into js_ocaml in ocsigen/js_of_ocaml#1724 and released along in 6.0.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 21, 2025
@stepbrobd stepbrobd requested a review from vbgl February 24, 2025 01:27
Comment thread pkgs/development/tools/ocaml/js_of_ocaml/compiler-wasm.nix Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
menhirSdk,

I think this library is not needed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread pkgs/top-level/ocaml-packages.nix Outdated
@vbgl
Copy link
Copy Markdown
Contributor

vbgl commented Feb 24, 2025

and please set minimalOCamlVersion to at least "4.12". Thanks.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
js_of_ocaml
js_of_ocaml-compiler

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works because js_of_ocaml is brought in by js_of_ocaml-compiler, and only js_of_ocaml is needed as indicated in wasm_of_ocaml-compiler.opam (some extra building is required if we use js_of_ocaml-compiler instead of js_of_ocaml)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the opposite: only js_of_ocaml-compiler is needed, js_of_ocaml brings in both.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! didn't check carefully in default.nix

@vbgl vbgl merged commit 2938bfe into NixOS:master Feb 24, 2025
@vbgl
Copy link
Copy Markdown
Contributor

vbgl commented Feb 24, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants