Skip to content

Revert "nixos/rustic: init module" - #373035

Merged
emilylange merged 1 commit into
masterfrom
revert-372935-rustic-module
Jan 11, 2025
Merged

Revert "nixos/rustic: init module"#373035
emilylange merged 1 commit into
masterfrom
revert-372935-rustic-module

Conversation

@emilylange

Copy link
Copy Markdown
Member

Reverts #372935 as per #372935 (comment).

@github-actions github-actions Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 11, 2025
@Ekleog

Ekleog commented Jan 11, 2025

Copy link
Copy Markdown
Member

Makes sense to me. I'm not sure I agree with your other comments, but let's go through another more in-depth round of review, leaving some time for everyone to comment.

@Ekleog

Ekleog commented Jan 11, 2025

Copy link
Copy Markdown
Member

(For the "is missing tests", does nixos now have a policy to not add modules without tests? I was the one pushing everyone to integrate tests at the time, but since then I've seen that people land updates that break passthru.tests without even commenting on why, so my personal motivation at writing new tests has gone way down)

@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 11, 2025
@emilylange

Copy link
Copy Markdown
Member Author

(For the "is missing tests", does nixos now have a policy to not add modules without tests? I was the one pushing everyone to integrate tests at the time, but since then I've seen that people land updates that break passthru.tests without even commenting on why, so my personal motivation at writing new tests has gone way down)

There is no policy, no.

But given the complexity of the module, potential breakage, especially but not limited to rustic still being pre-1.0.0 and not involving the actual maintainer of the package, I personally find it reasonable to ask for one and as such brought it up as one of the point against the merge of the PR.

@emilylange
emilylange merged commit 2e0334e into master Jan 11, 2025
@emilylange
emilylange deleted the revert-372935-rustic-module branch January 11, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants