libstore: pass StorePath to realPathInHost - #16442
Merged
Ericson2314 merged 1 commit intoSep 9, 2026
Merged
Conversation
Ericson2314
reviewed
Sep 9, 2026
`realPathInHost` is only called with store paths, so accepting a `StorePath` avoids printing and parsing them again.
amaanq
force-pushed
the
derivation-builder-store-path
branch
from
September 9, 2026 00:56
938315c to
c39c9f0
Compare
Ericson2314
approved these changes
Sep 9, 2026
Member
|
This is an obvious solution, to a problem that @xokdvium pointed out, so I feel fine doing something close to a self-merge here. |
xokdvium
approved these changes
Sep 9, 2026
xokdvium
left a comment
xokdvium
left a comment
Contributor
There was a problem hiding this comment.
Seems fine from a glance with eyes half-open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
realPathInHostis only called with store paths, so accepting aStorePathavoids printing and parsing them again.Context
DerivationBuildernot require aStore#16381 (comment)Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.