libfetchers: Fix lazy attribute comparisons - #16430
Draft
xokdvium wants to merge 1 commit into
Draft
Conversation
xokdvium
added
the
backport 2.35-maintenance
github-actions
Bot
added
the
fetching
Merged
xokdvium
force-pushed
the
fix-lazy-attr-comparison
branch
from
September 5, 2026 23:13
f336db8 to
2ad624c
Compare
Contributor
Author
|
Ah amazing, revCount in shallow clones also doesn't work properly here. @roberth any thoughts? So it was being compared after all (though just by pointer equaility - which is not good). I do think that deep comparison is the right approach here of course but something needs to be done about not relying on pointer equality. I'll do a quick hack for this particular issue but I hope you have better ideas. |
Contributor
Author
|
Maybe we can indicate a lack of |
xokdvium
marked this pull request as draft
September 5, 2026 23:30
xokdvium
force-pushed
the
fix-lazy-attr-comparison
branch
from
September 5, 2026 23:49
2ad624c to
56c9611
Compare
Contributor
Author
|
Ok looks like I hacked up something, but I utterly hate it. Seems like the only way is to short-circuit Attr comparison of attribute is unavailable - i.e. missing like with revCount case. Maybe it's fine and I'm overthinking it. |
Comparison was erroneously shallow, which lead to lock file comparison returning garbage on `flake update` commit message. Also make code more concise (specifically operator<=> defaulting also defaults operator== and operator!=, though defining it explicitly doesn't - only = default does that).
xokdvium
force-pushed
the
fix-lazy-attr-comparison
branch
from
September 6, 2026 09:35
56c9611 to
ce0aa19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Comparison was erroneously shallow and comparing pointers without also considering LazyAttr producing the same value equivalent with another non-lazy attr, which lead to lock file comparison returning garbage on
flake updatecommit message (and stderr output).Also make code more concise (specifically operator<=> defaulting also defaults operator== and operator!=, though defining it explicitly doesn't - only = default does that).
Context
Reported in #15772 (comment). cc @SuperSandro2000
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.