sandydoo's libstore-c: add accessor-based path info API - #16420
Open
roberth wants to merge 9 commits into
Open
Conversation
Exposes store path metadata via an opaque handle with getters.
Pass context in the callback to match existing callback APIs. Update and improve tests.
github-actions
Bot
added
documentation
c api
roberth
force-pushed
the
feat-query-path-info
branch
from
September 3, 2026 00:59
74bca76 to
5a123e1
Compare
tomberek
reviewed
Sep 3, 2026
| auto mutInfo = std::make_shared<nix::ValidPathInfo>(*cppInfo); | ||
| mutInfo->references.insert(outPath->path); | ||
| mutInfo->references.insert(drvPath->path); | ||
| mutInfo->sigs.insert(nix::Signature::parse("key1:c2ln")); |
Contributor
There was a problem hiding this comment.
c2ln feel like it should be a sig parse error?
Contributor
There was a problem hiding this comment.
I guess it works. Length isn't checked until later.
tomberek
reviewed
Sep 4, 2026
| if (!path_info->info->ca) | ||
| return nix_set_err_msg(context, NIX_ERR_KEY, "Store path is not content-addressed"); | ||
| if (callback) { | ||
| auto res = renderContentAddress(*path_info->info->ca); |
Contributor
There was a problem hiding this comment.
Suggested change
| auto res = renderContentAddress(*path_info->info->ca); | |
| auto res = path_info->info->ca->render(); |
known to be not false a few lines above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.