Repository navigation
Conversation
Write the requested v1, v2 or v3 metadata version and reject unsupported versions before emitting bytes. Pad v3 metadata to an eight-byte boundary without changing the v1/v2 layouts. Add version, alignment and record boundary regressions and document version-matched records. Core and live package tests pass; Databento’s CLI decodes v3 output across six schemas. Co-Authored-By: GPT-6 <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Metadata.Writeroutes every non-v1 version towriteV2, which hardcodes theDBN\x02prefix. Asking for v3 therefore silently produces v2 metadata, including when the following records use v3 layouts (notably statistics). Unsupported versions are silently downgraded too.Change
Validation
GOWORK=off go test . ./livepassed, including the existing Ginkgo suite.dbnCLI 0.71.0 for trades, MBO, MBP1, MBP10, OHLCV and statistics. The statistics fixture uses a quantity above 32 bits to exercise the v3 layout.The alignment follows Databento's encoder.