Cleanup Orphan node objects - #9
Merged
Merged
Conversation
| if err != nil { | ||
| return fmt.Errorf("failed to get in-cluster config: %v", err) | ||
| } | ||
| clientset, err := kubernetes.NewForConfig(config) |
There was a problem hiding this comment.
suggestion: consider a helper to initialise and reuse the client
|
|
||
| // Refresh updates manager node groups from the provider state. | ||
| func (m *Manager) Refresh() error { | ||
| defer CleanUpOrphanNodeObject() |
There was a problem hiding this comment.
suggestion: consider wrapping in a function that logs if cleanup fails so that errors aren't silently discarded.
sheyabernstein
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: