Add a script to launch this app#5
Open
hjain-perforce wants to merge 3 commits into
Open
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated by P4-Integ-Orch for issue #1.
Excellent! Both issues have been fixed:
Review Feedback Round 2 - Addressed
Both issues fixed:
✅ Issue Add a script to launch this app #1 (launch.sh:110) - Replaced explicit
cleanupcall withexit 0. The trap handler will automatically invoke cleanup when the script exits, avoiding redundant calls and the error from cleanup's ownexit 0.✅ Issue Add a script to launch this app #2 (launch.bat:51) - Removed trailing space from
findstr ":%PORT% "pattern, now usingfindstr ":%PORT%"to be more robust across different Windows versions and netstat output formats.