Conversation
kylophone
force-pushed
the
motion_v2
branch
2 times, most recently
from
106f62f to
d54d053
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motion_v2exploits the linearity of convolution, i.e. SAD(blur(A), blur(B)) = SAD(blur(A - B)). Difference, blur, and absolute-sum are fused into a single pass, which eliminates the need to store blurred frames between calls and enabling stateless per-frame execution. This fixes a threading bottleneck inherent to the originalmotionfeature extractor. The plots below show howvmafas calculated withmotionvsmotion_v2scales with the threading modes implemented as part of #1482.