Add additional helper methods to TagList#1240
Merged
Merged
Conversation
Add a TagList.create method that accepts an Iterable of tags, a method for getting the static empty TagList singleton, and a collector for creating a TagList from a Stream of Tags. For cases where some global tags are computed and re-used, using these methods can be beneficial since it will do the conversion to an ArrayTagSet once.
brharrington
reviewed
Jun 1, 2026
| * limitations under the License. | ||
| */ | ||
| public class TagListTest { | ||
| @Test |
Contributor
There was a problem hiding this comment.
Can we use 2-space indent to be consistent with the rest of the repo?
- Use 2-space indentation and move the license header to the top of the file to match repo conventions. - Fix CustomTag.equals to compare against the Tag interface instead of casting to CustomTag, which would throw ClassCastException for other Tag implementations and violated the symmetry contract. - Move the mixed Tag-implementation case into the collected stream in testCollector so it actually exercises the collector with a heterogeneous stream. - Drop trailing blank javadoc lines on TagList.empty()/toTagList().
brharrington
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a TagList.create method that accepts an Iterable of tags, a method for getting the static empty TagList singleton, and a collector for creating a TagList from a Stream of Tags.
For cases where some global tags are computed and re-used, using these methods can be beneficial since it will do the conversion to an ArrayTagSet once.