fix(runner): recalc fontSize 0.5s after window resize, fix #18653#19218
fix(runner): recalc fontSize 0.5s after window resize, fix #18653#19218ilharp wants to merge 1 commit into
fontSize 0.5s after window resize, fix #18653#19218Conversation
…8653 部分移动端浏览器(如微信 WebView)加载或刷新时有概率将 window resize 为一个 height 很小的大小,之后又恢复。经过测试在 window resize event 0.5s 之后再次尝试计算 fontSize 可解决。 影响范围:v3.7.0-alpha.27 以来的所有版本 详情看 NervJS#18653 中评论
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTwo build runner HTML generators are updated: Vite and Webpack5 now both add a 500ms delayed re-execution of the document root font-size calculation in their window resize event handlers, changing the callback from immediate-only execution to immediate plus delayed execution. ChangesResponsive font-size recalculation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
这个 PR 做了什么? (简要描述所做更改)
部分移动端浏览器(如微信 WebView)加载或刷新时有概率将 window resize 为一个 height 很小的大小,之后又恢复。经过测试在 window resize event 0.5s 之后再次尝试计算 fontSize 可解决。
影响范围:v3.7.0-alpha.27 以来的所有版本
详情看 #18653 中评论
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
Summary by CodeRabbit
发版说明